Mark VandenBrink 12 年之前
父節點
當前提交
02f728bdbc
共有 4 個文件被更改,包括 12 次插入2 次删除
  1. 2 0
      README.md
  2. 1 1
      mpeg.lisp
  3. 4 0
      taglib-tests.asd
  4. 5 1
      taglib.asd

+ 2 - 0
README.md

@@ -18,6 +18,8 @@ Notes II:
   that it is tough to compensate for all their errors.
 * The parsing of MP3 audio properties (mpeg.lisp) is far from complete, especially when dealing with odd case WRT Xing headers.
 * I've parsed just enough of the MP4 atoms/boxes to suit the needs of this tool.  l-smash appears to parse all boxes.  Maybe one day this lib will too.
+* WRT error handling: in some cases, I've made them recoverable, but in general, I've went down the path of erroring out when
+  I get problems.
 * I've run this tool across my 19,000+ audio collection and compared the results to some of the tools above, with little to no variations.
   That said, I have a pretty uniform collection, mostly from ripping CDs, then iTunes purchases/matched, and the Amazon matched. YMMV
 

+ 1 - 1
mpeg.lisp

@@ -399,7 +399,7 @@
 						   (setf last-bit-rate (bit-rate f)))))
 				:read-payload nil)
 	(if (or (zerop n-frames) (zerop bit-rate-total))
-		(values nil nil nil) 
+		(values nil nil nil)
 		(values vbr (float (/ bit-rate-total n-frames)) total-len))))
 
 (defun get-mpeg-bit-rate-ff (in)

+ 4 - 0
taglib-tests.asd

@@ -1,6 +1,10 @@
 ;;; taglib-tests.asd
 ;;; Copyright (c) 2013, Mark VandenBrink. All rights reserved.
 ;;;
+
+;;; should only be set when on markv machines...
+(pushnew :I-AM-MARKV *features*)
+
 (asdf:defsystem #:taglib-tests
   :description "Simple demo/test code for taglib"
   :author "Mark VandenBrink"

+ 5 - 1
taglib.asd

@@ -1,8 +1,12 @@
 ;;; taglib.asd
 ;;; Copyright (c) 2013, Mark VandenBrink. All rights reserved.
 ;;;
+
+;;; should only be set when on markv machines...
+(pushnew :I-AM-MARKV *features*)
+
 (asdf:defsystem #:taglib
-  :description "Pure Lisp implementation to read (and write?) tags"
+  :description "Pure Lisp implementation to read (and write, perhaps, one day) tags"
   :author "Mark VandenBrink"
   :license "Public Domain"
   :depends-on (#:log5 #:alexandria)